fix: Support for generating enums when enums definition has null value #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41ec6eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
reviewed
Aug 29, 2024
.changeset/real-penguins-fold.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "openapi-typescript": minor | |||
There was a problem hiding this comment.
Suggested change
| "openapi-typescript": minor | |
| "openapi-typescript": patch |
I would consider this a patch because this doesn’t add new functionality; it fixes a bug, no?
|
Looks great, and great tests! But let’s make this a |
|
@drwpow forgot about this, updated to patch |
|
@drwpow bumping this |
drwpow
approved these changes
Oct 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR change? Link to any related issue(s).
#1872
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)