Skip to content

fix(openapi-typescript): type errors generated under enumValues #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Aug 20, 2024

Changes

reference: #1856

In injectFooter, by redefining ReadonlyArray, type inference for ReadonlyArray is correctly applied to the array type.

How to Review

All test cases should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@phk422 phk422 requested a review from a team as a code owner August 20, 2024 15:02
Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: d5fcfa2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you!

@drwpow drwpow merged commit 21fb8b0 into openapi-ts:main Aug 29, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
@phk422 phk422 deleted the fix/enumValues branch August 30, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants