-
-
Notifications
You must be signed in to change notification settings - Fork 533
feat: Japanese translation for docs #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you so much for opening! Re: search, that’s all automatic! Algolia scans the published site on its own, so there’s nothing to do on our end. Yes there is a slight delay before Japenese docs would appear in search yes but not long (~1 day) Is it OK if I push an empty commit to |
ok! yes please! |
@@ -7,7 +7,7 @@ description: Quickstart | |||
|
|||
openapi-typescript turns [OpenAPI 3.0 & 3.1](https://spec.openapis.org/oas/latest.html) schemas into TypeScript quickly using Node.js. No Java/node-gyp/running OpenAPI servers necessary. | |||
|
|||
The code is [MIT-licensed](https://github.com/openapi-ts/openapi-typescript/blob/main/packages/openapi-typescript/LICENSE") and free for use. | |||
The code is [MIT-licensed](https://github.com/openapi-ts/openapi-typescript/blob/main/packages/openapi-typescript/LICENSE) and free for use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix for the invalid link mentioned in the Changes same for zh doc.
Oh shoot it’s not the developer permissions; it’s that Cloudflare just doesn’t deploy previews for forks at all 🤔. My commit didn’t do anything. I’ve just always assumed. Anyway, made a docs preview to inspect: https://ja-preview.openapi-ts.pages.dev/ Overall, the dev version is pretty reliable! But just in case others wanted to inspect it easily too. (Also to check Cloudflare didn’t have a build error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! Great work with this, thank you! 🙏 Skimming through the pages, they seem good to me (minus me not being able to read Japanese). Docs all seem to be working well.
But let me know when you’re ready to merge this! This looks good from my end. After merge, I’ll trigger a manual reindex from Algolia so that appears in search as soon as possible.
Thank you for the review! |
As a native Japanese speaker, thank you and great work @yoshi2no! I took a look the diff and the preview quickly and could not find any issues for now. I would like to review Japanese docs if needed, so feel free to mention me if you are finding a reviewer for that! |
Thank you for your comment and for taking the time to review! 🙏 |
Changes
ref: #1815
Enable noUncheckedIndexedAccess in TSConfig
(en, zh)ja
configI believe there shouldn’t be any content missing from the latest documents since I’m referring to the most up-to-date version.
How to Review
Is there anything I need to do to enable this for the Japanese docs?Checklist
N/A