-
-
Notifications
You must be signed in to change notification settings - Fork 528
fix: keyedParameters use unique key #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e63d90a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉 Looks great, thank you!
Great test too. We’ll need a patch
changeset in order to release this though (see comment above)
Ah I see—this is caused by the hoisted parameters behavior. It’s important that test still passes without modification but any implementation we can take that makes the test suite pass is fine by me. |
fix it. |
@drwpow :There are issues with different types of parameters with the same name. I hope this bug can be released as soon as possible. Thank you! |
@liangskyli This looks great, thanks for fixing the tests! We’ll need a |
fix: keyedParameters use unique key
I have already create proud-pugs-clean.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Will cut a release now.
Changes
fix: #1798
What does this PR change? Link to any related issue(s).
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)