Skip to content

fix: keyedParameters use unique key #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

liangskyli
Copy link
Contributor

Changes

fix: #1798
What does this PR change? Link to any related issue(s).

How to Review

How can a reviewer review your changes? What should be kept in mind for this review?

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@liangskyli liangskyli requested a review from a team as a code owner August 14, 2024 13:25
Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: e63d90a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉 Looks great, thank you!

Great test too. We’ll need a patch changeset in order to release this though (see comment above)

@drwpow
Copy link
Contributor

drwpow commented Aug 14, 2024

Ah I see—this is caused by the hoisted parameters behavior. It’s important that test still passes without modification but any implementation we can take that makes the test suite pass is fine by me.

@liangskyli
Copy link
Contributor Author

Ah I see—this is caused by the hoisted parameters behavior. It’s important that test still passes without modification but any implementation we can take that makes the test suite pass is fine by me.

fix it.

@liangskyli
Copy link
Contributor Author

@drwpow :There are issues with different types of parameters with the same name. I hope this bug can be released as soon as possible. Thank you!

@drwpow
Copy link
Contributor

drwpow commented Aug 29, 2024

@liangskyli This looks great, thanks for fixing the tests! We’ll need a patch changeset (see comment) to release though!

fix: keyedParameters use unique key
@liangskyli
Copy link
Contributor Author

I have already create proud-pugs-clean.md file

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will cut a release now.

@drwpow drwpow merged commit 08bde72 into openapi-ts:main Aug 29, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when use header and cookie, and use same name(param1), header always return never
2 participants