Skip to content

test: remove unused nanoid import in index.bench.js #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Aug 2, 2024

It is not declared in package.json, so running npx vite bench fails.

It is not declared in package.json, so running `npx vite bench` fails.
@gzm0 gzm0 requested a review from a team as a code owner August 2, 2024 12:24
Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 6e0ad01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@drwpow drwpow merged commit 224bf22 into openapi-ts:main Aug 2, 2024
7 checks passed
@drwpow
Copy link
Contributor

drwpow commented Aug 2, 2024

Also a note—I’ve found the benchmarking to be wildly inconsistent 😓. It’s still in beta for Vitest, and I think we should have another alternative.

Or, put another way, the absolute numbers fluctuate wildly. But the relative measurements have some consistency (i.e. openapi-fetch being XX% faster than another package stays consistent-ish).

It’s been on my list to come up with more reliable benchmarks—would love your thoughts if there’s a better way to profile performance.

Also like I said before, anecdotally I haven’t had good experiences with performance regression tests (or, at least, not without an entire team at a company dedicated to maintaining them, and we don’t have that for this OSS project). CI (especially free CI) just fluctuates too widely with resources to be reliable. But I’m strongly in favor of manually-run benchmarking, that can be run when we want to see if something moves the needle up or down. And I think there’s improvements to be made in this area here, and I welcome your input! 🙏

@gzm0 gzm0 deleted the remove-import branch August 5, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants