perf: remove unnecessary async keywords
#1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13a5866 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
approved these changes
Aug 2, 2024
They simply increase code size (perf in this sense).
|
Changeset added, rebased, squashed. |
drwpow
approved these changes
Aug 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove unnecessary
asynckeywords in object returned fromcreateClient.They simply increase code size (perf in this sense).
I stumbled upon this when working on #1791 / #1526.
I have checked that
dist/index.min.jsstill contains theasynckeyword, so at least when minified with esbuild, this really contributes to bundle size.How to Review
asyncdoes not hint to the JIT.Checklist
All points N/A.
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)