Remove undefined from additionalProperties union #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e0f0cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
changed the title
drwpow
force-pushed
the
addl-properties-no-undef
branch
from
ef03c56 to
104bd62
Compare
Deploying openapi-ts with
|
| Latest commit: |
4e0f0cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7998dd1d.openapi-ts.pages.dev |
| Branch Preview URL: | https://addl-properties-no-undef.openapi-ts.pages.dev |
drwpow
force-pushed
the
addl-properties-no-undef
branch
2 times, most recently
from
817a603 to
ed1dcbf
Compare
drwpow
commented
Aug 2, 2024
| @@ -46,7 +54,8 @@ describe("transformSchemaObject > object", () => { | |||
| }, | |||
| want: `{ | |||
| property?: boolean; | |||
| [key: string]: string | undefined; | |||
| } & { | |||
| [key: string]: string; | |||
There was a problem hiding this comment.
Note: this intersection seems a little awkward, but is necessary for TypeScript to work properly in most cases (here, you’d get some error like “property string not assignable to type boolean | undefined”).
drwpow
force-pushed
the
addl-properties-no-undef
branch
2 times, most recently
from
ec58bc9 to
747f69c
Compare
drwpow
force-pushed
the
addl-properties-no-undef
branch
from
747f69c to
4e0f0cf
Compare
Merged
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1732, #1737, and other related issues mentioning this behavior. Removes the
| undefinedfrom theadditionalPropertiesunion that is a behavior change from 6.x.How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)