Skip to content

Automatically stale and close issues #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

kerwanp
Copy link
Contributor

@kerwanp kerwanp commented Aug 1, 2024

Introduction

This is a pull request as well as an enhancement proposal for the repository.

There are issues created in 2021 that are still opened, some of them might be relevant but not enough to receive any updates. To avoid accumulating issues, I think it would be interesting to automatically stale and close issues that does not receive any update.

Changes

This pull requests adds a new automated workflow to automatically mark issues as stale and close them using the Stale Github Action.

It works as the following:

  1. After 90 days without activity, the issue is marked as stale with the following message

"This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed."

  1. After 7 days of being marked as staled, the issue is closed with the following message

"This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem."

It is possible to label issues with Issue accepted to ensure that they will never be closed automatically.

@kerwanp kerwanp requested a review from a team as a code owner August 1, 2024 10:28
Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 4ab1554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kerwanp kerwanp requested a review from drwpow August 1, 2024 10:29
@kerwanp
Copy link
Contributor Author

kerwanp commented Aug 1, 2024

@drwpow what do you think?

@drwpow
Copy link
Contributor

drwpow commented Aug 1, 2024

I’m in favor of this. I think we’re at a point now where the number of issues opened do need to get cleaned up. While sometimes we may close an issue that may still be present, I think it will help the quality of issues as the stale ones usually contain no reproductions and contain too much missing info for it to be a quick, actionable fix.

It is possible to label issues with Issue accepted to ensure that they will never be closed automatically.

I really like this. There will definitely be some issues where they may go stale, not from lack of interest or missing info, but just because they are particularly challenging problems.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Worth trying.

With these GitHub Actions tweaks, it sometimes takes several tries (or at least, it does for me—you may be better than I am 😄). Either way I don’t mind approving followups/tweaks to this

@kerwanp kerwanp merged commit 3694a3e into openapi-ts:main Aug 6, 2024
7 checks passed
@ngraef ngraef mentioned this pull request Aug 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants