Skip to content

[ci] release #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[ci] release #1789

merged 1 commit into from
Jul 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

@github-actions github-actions bot requested a review from a team as a code owner July 30, 2024 16:06
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying openapi-ts with  Cloudflare Pages  Cloudflare Pages

Latest commit: f3d2b0e
Status: ✅  Deploy successful!
Preview URL: https://d0f853bc.openapi-ts.pages.dev
Branch Preview URL: https://changeset-release-main.openapi-ts.pages.dev

View logs

@kerwanp kerwanp requested a review from drwpow July 30, 2024 16:08
@kerwanp
Copy link
Contributor

kerwanp commented Jul 30, 2024

@drwpow need review for release

@drwpow
Copy link
Contributor

drwpow commented Jul 30, 2024

@kerwanp Ah so with [ci] release PRs, you have to force merge.

What to loon for:

  1. Versions make sense (e.g. you’re publishing a patch version, not a major version
  2. Quickly verify that all meaningful changes are accounted for in changelogs (that’s why I ask people to write changesets ad a prereq to mergr, but sometimes things can slip past and it’s helpful to quickly review the PRs merged since the last release

If all that looks good, then we’ll override the merge to deploy. Reason is I just need to fix the permissions. By default bots can’t run GitHub Actions jobs. No job runs, no passing statuses. So we either need to bypass required status checks for this one bot. Or perhaps there’s another way (some PRs have “bot user” accounts set up where it’s an actual login, which can run actions but it’s a headache to set up and maintain).

So all that said, happy to release, and we’ll work to fix the issue so any maintainer can (while still requiring passing status checks)

@drwpow drwpow merged commit 9e0114a into main Jul 30, 2024
3 checks passed
@drwpow drwpow deleted the changeset-release/main branch July 30, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants