Skip to content

feat: add dedupeEnums option #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Jul 22, 2024

Changes

reference:#1683

How to Review

The tests should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@phk422 phk422 requested a review from a team as a code owner July 22, 2024 03:53
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: a91d001

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phk422 phk422 force-pushed the feature/dedupeEnums branch 3 times, most recently from f7b6542 to ecfd686 Compare July 22, 2024 05:31
@phk422 phk422 force-pushed the feature/dedupeEnums branch from ecfd686 to 13aa4fd Compare July 22, 2024 05:32
@Amixx
Copy link

Amixx commented Jul 30, 2024

when could this me merged? really looking forward to this feature!

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test, and good feature, thank you!

@drwpow
Copy link
Contributor

drwpow commented Jul 30, 2024

Let me know if you’d rather publish as a patch or minor; either is fine.

@phk422 phk422 requested a review from drwpow July 31, 2024 12:24
@drwpow drwpow merged commit b1bbe62 into openapi-ts:main Jul 31, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
@phk422 phk422 deleted the feature/dedupeEnums branch August 1, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants