fix: add explicit import of performance to fix bazel compatibility issues #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e4f7a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
approved these changes
Jul 19, 2024
|
@drwpow Added a changeset, but it is my first time using the tool. Let me know if it looks ok. |
|
Looks great, thank you! |
Merged
kerwanp
pushed a commit
to kerwanp/openapi-typescript
that referenced
this pull request
Jul 29, 2024
…sues (openapi-ts#1772) * fix: add explicit import of performance to fix bazel compatibility issues * add changeset --------- Co-authored-by: Ashwin Madavan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ReferenceError: performance is not definederrorimport { performance } from "node:perf_hooks"wheneverperformanceis used in the code.How to Review
performance.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)