Skip to content

feat: Add the inject option #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Jul 17, 2024

Changes

#1754 - Add the inject option

How to Review

All the tests should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@phk422 phk422 requested a review from a team as a code owner July 17, 2024 01:35
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 4ec9175

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phk422 phk422 force-pushed the feature/inject-option branch from d6c1bc6 to 89f276d Compare July 17, 2024 01:39
@phk422 phk422 force-pushed the feature/inject-option branch from 89f276d to b2151ef Compare July 17, 2024 01:43
@@ -0,0 +1,6 @@
---
"openapi-typescript-docs": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: We don’t need to version the docs; they always get released on merge to main. Should make sure these are ignored from changesets.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature makes sense, and I think would be useful to many people. Thank you!

@drwpow drwpow merged commit 0ce35d7 into openapi-ts:main Jul 17, 2024
7 checks passed
@kerwanp kerwanp mentioned this pull request Jul 18, 2024
1 task
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
* feat: Add the inject option

* Create little-pets-perform.md
@phk422 phk422 deleted the feature/inject-option branch September 10, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants