fix: --properties-required-by-default flag

[michalfedyna]

Changes

Fix --properties-required-by-default flag not working. #1651

How to Review

It was just simple typo.

Checklist

• Unit tests updated
• docs/ updated (if necessary)
• pnpm run update:examples run (only applicable for openapi-typescript)

[changeset-bot]

🦋 Changeset detected

Latest commit: 81ce5a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
openapi-typescript	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[michalfedyna]

@drwpow any chances of fast approve and release?

[drwpow]

Thanks for the fix; this looks good to me! I’d love to add a test for this so this doesn’t regress in the future. And also please add a patch changeset (see comment) so the version can be bumped and released. But otherwise, this looks good and would be happy to merge when both of those items are in.

[michalfedyna]

@drwpow Changeset done. It will be hard to test that part. The problem comes from cli.js not being part of the build process and static analysis not being done on that file. I will take some time over the weekend and make it work if you wish. But for now is it possible to merge that change? It will be helpful for me at work.

[drwpow]

So there are CLI tests for flags already. A lot of them had been moved into the Node API tests, but for this change, we could just do a simple expect(…).toMatchFileSnapshot() test to make sure it’s working as-expected. It would also just help prevent these regressions in the future!

[michalfedyna]

@drwpow Should be done! You can run diff ./examples/github-api.ts ./examples/github-api-required.ts to check if flag works as you expect.

[michalfedyna]

And I'm testing against ./example/github-api-required.ts

[drwpow]

Awesome, thank you so much! That works—just something that verifies a) this is the correct fix, and b) we’ll see a test failure if this regresses. That saves a ton of work in the long term; appreciate it!

[michalfedyna]

Great, thanks!