fix: Enum option cannot generate enums if values are not valid property names #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replace only the invalid characters with "_" if they are part of the name
🦋 Changeset detectedLatest commit: 59c6033 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
reviewed
Jul 15, 2024
Thank you for the review! I have added the changeset. |
Merged
kerwanp
pushed a commit
to kerwanp/openapi-typescript
that referenced
this pull request
Jul 29, 2024
…ty names (openapi-ts#1761) * chore(test): add InvalidPropertyNameChars with enum flag * fix: Quote the name if it consists entirely of invalid characters and replace only the invalid characters with "_" if they are part of the name * chore: fix lint error * chore: add changeset patch md
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1722
Made the following changes:
The existing logic that replaces invalid characters within a key name with "_" has been kept. Additionally, by quoting the name when it consists entirely of invalid characters, it helps prevent errors.
How to Review
Ensure that the test passes.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)