Skip to content

fix: resolve issue with saving output using full file paths #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Jul 5, 2024

Changes

Fix #1745

How to Review

Tests added; tests should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@phk422 phk422 requested a review from a team as a code owner July 5, 2024 08:17
Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: 83ca0b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

* @param {string} output - The output path to be transformed.
* @returns {URL} The transformed file URL.
*/
function normalizeOutput(output) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good helper, thank you!

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drwpow drwpow merged commit 69f0628 into openapi-ts:main Jul 8, 2024
7 checks passed
@phk422 phk422 deleted the fix-output branch July 9, 2024 01:11
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
…ts#1747)

* fix: resolve issue with saving output using full file paths

* chore: lint code

* fix: normalizeOutput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error saving output on windows with full file paths instead of relative
2 participants