Skip to content

fix: Generate valid types for referenced nested properties #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

avaly
Copy link
Contributor

@avaly avaly commented Jul 4, 2024

Changes

Closes #1742

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@avaly avaly requested a review from a team as a code owner July 4, 2024 12:13
Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 884b14b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@avaly avaly force-pushed the fix/reference-nested-properties-types branch from 1b13af3 to 4aa124b Compare July 4, 2024 12:21
@avaly avaly force-pushed the fix/reference-nested-properties-types branch from 4aa124b to 884b14b Compare July 4, 2024 12:23
Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, and great tests, thank you!

@drwpow drwpow merged commit 8f6ec20 into openapi-ts:main Jul 4, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
@avaly avaly deleted the fix/reference-nested-properties-types branch July 4, 2024 17:45
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: references to nested properties in schemas generate invalid types
2 participants