Skip to content

Remove sourceRoot configuration to enable proper source file mapping #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Jun 26, 2024

Hi, @drwpow! I've encountered an issue where VSCode's debugger cannot correctly navigate to the source files.
image

Changes

  • Removed sourceRoot configuration from tsconfig.json .
  • This fix resolves the issue where source maps were not correctly mapping to the original TypeScript files.

…ure proper source mapping during local debugging
@phk422 phk422 requested a review from a team as a code owner June 26, 2024 02:12
Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 6a6f237

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch; I think this isn’t intentional

@drwpow drwpow merged commit d3d0fcf into openapi-ts:main Jun 26, 2024
7 checks passed
@phk422 phk422 deleted the phk422 branch June 27, 2024 01:04
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants