Skip to content

Fix schema objects with default + nullable #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented May 19, 2024

Changes

Fixes an issue called out in the v7 Preview thread where a schema object with default + nullable wouldn’t generate as-expected.

How to Review

  • Tests added; tests should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented May 19, 2024

⚠️ No Changeset found

Latest commit: b0201b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow force-pushed the default-not-nullable branch from 40bf33d to b0201b5 Compare May 19, 2024 18:55
Copy link

cloudflare-workers-and-pages bot commented May 19, 2024

Deploying openapi-ts with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0201b5
Status: ✅  Deploy successful!
Preview URL: https://ecae598b.openapi-ts.pages.dev
Branch Preview URL: https://default-not-nullable.openapi-ts.pages.dev

View logs

@drwpow drwpow merged commit 054d564 into main May 19, 2024
8 checks passed
@drwpow drwpow deleted the default-not-nullable branch May 19, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v7 Preview 🎉
1 participant