Skip to content

bump openapi-typescript-fetch version #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

ajaishankar
Copy link
Contributor

Changes

Bumps the version of openapi-typescript-fetch for benchmark

How to Review

No code changes, all tests should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Apr 29, 2024

⚠️ No Changeset found

Latest commit: 39a0cc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! You know I think I need to use a different method of running benchmarks, because Vitest’s is still marked beta and is unreliable. Will re-run benchmarks, and if you have any other solutions / suggestions, I’m all ears 🙏

@drwpow drwpow merged commit 32647c8 into openapi-ts:main May 8, 2024
6 checks passed
@ajaishankar
Copy link
Contributor Author

Thanks!

Was looking into the Hono framework and they use Mitata for their benchmarks

Not sure if it would make a difference.

Feel the benchmark tests should exercise more functionality like request/response serialization and middleware.

That would be a better comparison.

Sorry have not got a chance to look into adding those...

btw you might find their RPC strongly typed client/server implementation interesting...

@drwpow
Copy link
Contributor

drwpow commented May 9, 2024

Will take a look at Mitata! Probably anything will be an improvement over Vitest’s benchmarks.

btw you might find their RPC strongly typed client/server implementation interesting...

Oh that’s interesting! It looks like it uses Zod, which I personally wouldn’t want to use in this project because of the weight/runtime cost. But I’m sure in the inference piping it’s doing, there are probably some interesting ideas worth looking into. Good suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants