Do not add readonly on enum with the immutable option, #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test 'export' modifier on enum
🦋 Changeset detectedLatest commit: c59e10d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
reviewed
Apr 2, 2024
drwpow
approved these changes
Apr 3, 2024
|
Released in the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Readonly modifier is not applicable to Typescript enum.
This PR makes sure the readonly modifiers is not applied on enum when the --immutable option is used.
Related discussion
#1368 (comment)
How to Review
A question would be how to test this ? As I did not found a way to test with the global --immutable option.
Alternatively I added a test for the 'export' modifier that is used in the code.
Checklist
docs/updated (if necessary) (not necessary)pnpm run update:examplesrun (only applicable for openapi-typescript) (=> no changes)