Skip to content

[chore] Update benchmarks (again) #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[chore] Update benchmarks (again) #1586

merged 1 commit into from
Mar 6, 2024

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Mar 6, 2024

Changes

Benchmarks are hard. I find showing something rather than nothing is useful, but it needs so many caveats and asterisks. I also rounded the numbers (fairly) to reflect a lot of fluctuation they’ve had over time.

I feel like saying “openapi-fetch is faster” is an empty statement; benchmarks are important. However getting accurate benchmarks on how much faster is so tricky to get right. But I will always accept PRs like this that improve the accuracy and fairness of these benchmarks.

My overall goal is really not to be X-amount faster than alternatives. My only goal is to show that this is one of the fastest, if not the fastest, since I think fetch speed is so critical to applications.

How to Review

N/A

Checklist

N/A

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 3ed5fad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow merged commit f7ce0f5 into main Mar 6, 2024
@drwpow drwpow deleted the bench-notes branch March 6, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant