Skip to content

Chore: Enforce type imports #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Chore: Enforce type imports #1523

merged 1 commit into from
Jan 28, 2024

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Jan 28, 2024

Changes

Insignificant change: enforce type imports. It shouldn’t cause any difference in building the library (either final output or build speed). But it’s more technically-correct, and is clearer to the reader what imports have runtime implications and which don’t.

How to Review

  • Lint rules should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Jan 28, 2024

⚠️ No Changeset found

Latest commit: 9fbcabf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow merged commit 0a700ea into main Jan 28, 2024
@drwpow drwpow deleted the chore/enforce-type branch January 28, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant