Skip to content

Fix Redocly automatic config loading #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix Redocly automatic config loading #1453

merged 2 commits into from
Nov 22, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Nov 22, 2023

Changes

  • Fixes a bug where the --redoc flag had a test, but the automatic config loading did not, and it contained an error where it was trying to load a partial filepath. Also adds a test.
  • Updates deps
  • Also fixes a CLI output bug where it would accidentally print the input file twice instead of [input] → [output]

This doesn’t have a changeset because it’s a bugfix for the unreleased 7.x version.

How to Review

  • Test added; test should pass.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Nov 22, 2023

⚠️ No Changeset found

Latest commit: 33fe292

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow drwpow force-pushed the fix-redocly-config branch from ccb238d to c9e26a4 Compare November 22, 2023 04:14
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 33fe292
Status: ✅  Deploy successful!
Preview URL: https://b7934c56.openapi-ts.pages.dev
Branch Preview URL: https://fix-redocly-config.openapi-ts.pages.dev

View logs

@drwpow drwpow force-pushed the fix-redocly-config branch 19 times, most recently from 56e36e1 to 789f969 Compare November 22, 2023 05:00
@drwpow drwpow force-pushed the fix-redocly-config branch 2 times, most recently from 891f03f to 99ed917 Compare November 22, 2023 05:20
@drwpow drwpow force-pushed the fix-redocly-config branch from 99ed917 to 33fe292 Compare November 22, 2023 05:23
@drwpow drwpow merged commit e5f54f5 into main Nov 22, 2023
@drwpow drwpow deleted the fix-redocly-config branch November 22, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant