Fix defaultNonNullable behavior

[drwpow]

Changes

defaultNonNullable: true can’t make parameters required even if a default value is given (comment).

How to Review

• Tests should pass.

Checklist

• Unit tests updated
• docs/ updated (if necessary)
• pnpm run update:examples run (only applicable for openapi-typescript)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 01eb231

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	01eb231
Status:	✅  Deploy successful!
Preview URL:	https://5d4fc629.openapi-ts.pages.dev
Branch Preview URL:	https://fix-default-non-nullable.openapi-ts.pages.dev

View logs

[drwpow]

This new test asserts that a parameter with a default is ignored, but a response object with a default is not

[drwpow]

This seems like the dumbest solution to the problem, but I actually think it’s the correct one—parameters go through normal SchemaObject transformation, however, in this one scenario we apply different rules because of where they live (in any parameters object). I can’t think of a single scenario where this wouldn’t be true.

I also feel like the alternative—trying to override ctx.defaultNonNullable conditionally based on the parent—is a worse approach that could lead to other unintentional bugs.