Skip to content

Fix immutable types #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Fix immutable types #1443

merged 1 commit into from
Nov 18, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Nov 18, 2023

Changes

Fixes --immutable types in v7 (beta) (comment). Basically this was missing from some places it should have been, and present in some places it shouldn’t (and TS lets you place it in invalid places)

How to Review

  • Tests added

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

changeset-bot bot commented Nov 18, 2023

⚠️ No Changeset found

Latest commit: 8ab12a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Nov 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ab12a3
Status: ✅  Deploy successful!
Preview URL: https://637865c8.openapi-ts.pages.dev
Branch Preview URL: https://fix-immutable-types.openapi-ts.pages.dev

View logs

@drwpow drwpow force-pushed the fix/immutable-types branch from c055beb to 8ab12a3 Compare November 18, 2023 22:01
@drwpow drwpow merged commit 12cc079 into main Nov 18, 2023
@drwpow drwpow deleted the fix/immutable-types branch November 18, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant