[openapi-fetch] Support parseAs type inference #1442
Conversation
|
Deploying with
|
| Latest commit: |
30f9383
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://163dd43f.openapi-ts.pages.dev |
| Branch Preview URL: | https://feat-parse-as.openapi-ts.pages.dev |
| @@ -39,6 +39,15 @@ export type QuerySerializer<T> = ( | |||
| export type BodySerializer<T> = (body: OperationRequestBodyContent<T>) => any; | |||
|
|
|||
| export type ParseAs = "json" | "text" | "blob" | "arrayBuffer" | "stream"; | |||
| export type ParseAsResponse<T, K extends ParseAs> = K extends "text" | |||
| ? Awaited<ReturnType<Response["text"]>> | |||
| : K extends "blob" | |||
There was a problem hiding this comment.
The object was much cleaner, however, I was not able to get that working.
This is messier, but it does have the advantage of always falling back to the original type T whereas the cleaner object could return unknown
| : never | ||
| : never | ||
| Paths[P]["get"], | ||
| I[0]["parseAs"] extends ParseAs ? I[O]["parseAs"] : "json" |
There was a problem hiding this comment.
This seems like there’s a way to avoid this, but I couldn’t think of a way. I needed this in my version for TS to fall back to json if init?.parseAs was omitted
| ): Promise< | ||
| FetchResponse< | ||
| "get" extends infer T | ||
| ? T extends "get" |
There was a problem hiding this comment.
This was autogenerated TypeScript defs, not something I think is necessary. I cleaned this up to be more readable, and at least in the tests I didn’t notice any regressions
drwpow
changed the title
Changes
Adds parseAs inference; continues from #1428
How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)