Skip to content

Add Node 21 to CI #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add Node 21 to CI #1430

merged 1 commit into from
Nov 6, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Nov 6, 2023

Changes

CI-only change: Add Node 21.x to CI to test upcoming compatibility for when 22.x gets a stable release.

Will keep macos and windows locked to 20.x because those runners are expensive, and GitHub doesn’t queue those up too many (tried to expand the matrix to include these, but it just blocked the CI pipeline for a half hour)

How to Review

  • CI should pass (🤞)

Checklist

N/A

Copy link

changeset-bot bot commented Nov 6, 2023

⚠️ No Changeset found

Latest commit: 34cab5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow
Copy link
Contributor Author

drwpow commented Nov 6, 2023

🤔 I think the Cloudflare failure (docs site) is unrelated to this; I think it cached something it shouldn‘t have in the preview runner (not 100% sure, but not seeing that error locally). In either case, will fix separately from this PR.

Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 34cab5e
Status:🚫  Build failed.

View logs

@drwpow
Copy link
Contributor Author

drwpow commented Nov 6, 2023

Update: Cloudflare failure is from an upstream docs dependency bug unrelated to this PR or this library; will fix separately.

@drwpow drwpow merged commit 9663b74 into main Nov 6, 2023
@drwpow drwpow deleted the ci/node-21 branch November 6, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant