Skip to content

Update examples.md #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Update examples.md #1419

merged 1 commit into from
Nov 2, 2023

Conversation

WickyNilliams
Copy link
Contributor

Changes

adds example of using getter for dynamic header with openapi-fetch

How to Review

eyeball code, make sure it looks ok

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

add example of using getter for dynamic header
Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: fe33c7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@WickyNilliams
Copy link
Contributor Author

i just stumbled on this approach when adding such functionality to my own codebase. thought it might be useful in the docs as it feels simpler than the existing examples. seems to work just fine in my testing

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Whoa this is much smarter than some of the other examples! Now I’m tempted to delete the other ones in favor of this one 😄

@drwpow drwpow merged commit bebf08c into openapi-ts:main Nov 2, 2023
@WickyNilliams
Copy link
Contributor Author

Might be worth keeping them, but perhaps reorder so this is presented first :)

@WickyNilliams WickyNilliams deleted the patch-1 branch November 2, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants