Skip to content

Add Bun tests to CI #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Bun tests to CI #1367

wants to merge 1 commit into from

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Oct 5, 2023

Changes

CI only: run the test suite with Bun to ensure it’s working as expected (it’s only executing Vitest with Bun rather than Node, but will still flag any glaring issues)

Che

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e187d9
Status: ✅  Deploy successful!
Preview URL: https://35dfdc7e.openapi-ts.pages.dev
Branch Preview URL: https://bun-test.openapi-ts.pages.dev

View logs

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: 9e187d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@drwpow
Copy link
Contributor Author

drwpow commented Oct 5, 2023

@Fumaz 🤔 I added Bun testing to CI, however, when I revert #1364 locally, it passes all the same. I’m not able to recreate the error you were seeing that you were executing in Bun.

Is there something we can add here to recreate the error you were seeing originally?

@alexdotpink
Copy link
Contributor

Honestly I'm not entirely sure how to reproduce. I had to debug a lot to figure out why the body was always empty by the time it got to the parsing function, and that's how I found out that it was causing that issue. I don't think it matters but I am using my own API framework in my project, which uses Bun too.

@drwpow
Copy link
Contributor Author

drwpow commented Oct 8, 2023

I’m going to punt on this for now. This just slows down CI without any clear gain. As far as I’ve tested, openapi-fetch works with Bun just fine. We can re-add these, possibly using Bun’s native test suite, at a future date when I have time.

@drwpow drwpow closed this Oct 8, 2023
@drwpow drwpow deleted the bun-test branch October 8, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants