Skip to content

Fix all parameters optional #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Fix all parameters optional #1352

merged 1 commit into from
Sep 23, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Sep 23, 2023

Changes

(Might fix) #1340. Updates parameter optional behavior to not affect the components object; instead only happening on individual operation objects.

How to Review

  • Tests updated; tests should pass.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023

🦋 Changeset detected

Latest commit: 988158d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@drwpow drwpow force-pushed the fix/parameters-optional branch from 4d87a8d to 79fabff Compare September 23, 2023 02:21
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 988158d
Status: ✅  Deploy successful!
Preview URL: https://39579b11.openapi-ts.pages.dev
Branch Preview URL: https://fix-parameters-optional.openapi-ts.pages.dev

View logs

@drwpow drwpow force-pushed the fix/parameters-optional branch from 79fabff to 988158d Compare September 23, 2023 02:26
@drwpow drwpow merged commit 33b2c4f into main Sep 23, 2023
@drwpow drwpow deleted the fix/parameters-optional branch September 23, 2023 02:30
@github-actions github-actions bot mentioned this pull request Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant