Fix extra quote generated in components/responses with $refs #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
eebe6a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ca1b298.openapi-ts.pages.dev |
| Branch Preview URL: | https://fix-quote-char.openapi-ts.pages.dev |
🦋 Changeset detectedLatest commit: 7c0799e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: e39324e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
commented
Aug 30, 2023
| export const CLRF_RE = /\r\n/g; | ||
|
|
||
| /** Normalize all linebreaks to \n when reading files (for Windows tests) */ | ||
| export function readFile(filepath: fs.PathOrFileDescriptor): string { |
There was a problem hiding this comment.
Turns out this is built in to Vitest. So now we just use .toMatchFileSnapshot() instead
Sidenote for readers: I don’t like “traditional” snapshots for 2 reasons:
- I believe snapshots shouldn’t have any test runner artifacts/comments and should be 100% human-readable (otherwise, you miss changes)
- I don’t like making snapshots easy to update in a project like this—the snapshots are everything. I want failures to be meaningful, and require investigation into the why something changed, and to not disappear with the simple addition of a
-uflag.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1323. Adds test to prevent future regression.
This was just a small but devastating typo that went unnoticed for a while 😓
How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)