Skip to content

fix: Wrap nested readonly members #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

duncanbeevers
Copy link
Contributor

Changes

Parenthesise readonly types.
Closes #1319

How to Review

Verify the changes to parenthesise continue wrap to the expected types.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: b584666

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you! No feedback

@drwpow drwpow merged commit 3cf78b9 into openapi-ts:main Aug 22, 2023
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
@duncanbeevers duncanbeevers deleted the bug-nested-arrays branch August 22, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested immutable array schemas generate syntactically-invalid readonly readonly type
2 participants