Skip to content

Fix oneOf + empty object parent case #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix oneOf + empty object parent case #1287

merged 1 commit into from
Aug 9, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Aug 9, 2023

Changes

Fix #1277, where a "type": "object" SchemaObject has a oneOf property but no properties of its own.

How to Review

CI should pass

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 0e7ca25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e7ca25
Status: ✅  Deploy successful!
Preview URL: https://c54826dc.openapi-ts.pages.dev
Branch Preview URL: https://fix-oneof.openapi-ts.pages.dev

View logs

@drwpow drwpow merged commit 8a9d8ed into main Aug 9, 2023
@drwpow drwpow deleted the fix-oneof branch August 9, 2023 05:13
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneOf type generating Record<string,never> despite all types defined
1 participant