Fix remote path item object $refs #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8f5c94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Latest commit: |
c8f5c94
|
| Status: | ⚡️ Build in progress... |
drwpow
force-pushed
the
fix-remote-path-objecs
branch
from
a8b6eb1 to
c8f5c94
Compare
drwpow
commented
Jul 25, 2023
| @@ -3984,7 +3984,7 @@ export interface external { | |||
| */ | |||
| type?: "custom" | "lets_encrypt"; | |||
| }; | |||
| /** Custom Certificate Request */ certificate_request_custom: certificate_create_base[] & { | |||
| /** Custom Certificate Request */ certificate_request_custom: external["resources/certificates/models/certificate_create.yml"]["certificate_create_base"] & { | |||
There was a problem hiding this comment.
This was generating incorrectly before due to an unrelated bug. Fix was easy; we just didn’t have a test for it before.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1107. Also squashes quite a few remote schema bugs in the process, too 🎉
How to Review
Tests should pass.
Checklist
examples/directory updated (only applicable for openapi-typescript)