Rename all methods to UPPERCASE #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0374b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Latest commit: |
b0374b3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad3c1dcf.openapi-ts.pages.dev |
| Branch Preview URL: | https://method-names.openapi-ts.pages.dev |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renames all methods to uppercase to match the exact HTTP method naming, following discussion of #1218 (
get→GET,del→DELETE, etc.).The reasoning for this came mostly from SvelteKit’s prior art (discussion). It’s an exact overlap of concerns, and having read through this discussion and reasoning convinced me this was the right change. And as an added bonus, aligning with SvelteKit is never a bad thing 🙂.
How to Review
Tests should pass.
Checklist
examples/directory updated (only applicable for openapi-typescript)