support boolean json schema #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e0d0dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Oh right I can see that happening. I think omitting it is probably best for now. The test covers that scenario pretty well. |
drwpow
reviewed
Jul 18, 2023
| expect(transformSchemaObject(true as any, options)).toBe("unknown"); | ||
| }); | ||
| it("false", () => { | ||
| expect(transformSchemaObject(false as any, options)).toBe("never"); |
drwpow
approved these changes
Jul 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes #1227
I wasn't able to update the
SchemaObjecttype, addingboolean |to it broke other stuff with long & cryptic errors, includingChecklist
examples/directory updated (only applicable for openapi-typescript)