Fix remote schema maps #1212
Merged
Fix remote schema maps #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c25f227 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
fix-remote-schema-maps
branch
from
4a71732 to
39916e0
Compare
Deploying with
|
| Latest commit: |
c25f227
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c751f852.openapi-ts.pages.dev |
| Branch Preview URL: | https://fix-remote-schema-maps.openapi-ts.pages.dev |
drwpow
commented
Jul 7, 2023
| @@ -3965,7 +3965,160 @@ export interface external { | |||
| default: external["shared/responses/unexpected_error.yml"]; | |||
| }; | |||
| } | |||
| "resources/certificates/models/certificate_create.yml": unknown | |||
There was a problem hiding this comment.
🤔 this is probably a good sign
drwpow
force-pushed
the
fix-remote-schema-maps
branch
from
39916e0 to
4926934
Compare
drwpow
commented
Jul 7, 2023
| return getHintFromSchemaObject(path.slice(2), external); // skip array index at [1] | ||
| } | ||
| // if this is external, and the path is [filename, key], then the external schema is probably a SchemaMap | ||
| if (path.length === 2 && external) { |
There was a problem hiding this comment.
Very wacky logic, but it seems to check out 🤷
drwpow
force-pushed
the
fix-remote-schema-maps
branch
from
4926934 to
5d33b21
Compare
drwpow
force-pushed
the
fix-remote-schema-maps
branch
from
5d33b21 to
c25f227
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1131. There are likely some other bugs with deeply-nested remote schemas, but this fixes at least one.
The reason was in our
getHint()logic that traverses the nodePath, it wasn’t keeping track of remote filenames, which is necessary for certain inferences (the hints are necessary because partial schemas could be anything and still be valid—the only way to know is by tracing from the root). There’s probably a better solution than this, but this will do for now.How to Review
Tests should pass.
Checklist
examples/directory updated (only applicable for openapi-typescript)