Fix complex oneOf #1207
Merged
Fix complex oneOf #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 506d80b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
fix-complex-one-of
branch
from
12e1290 to
0603110
Compare
Deploying with
|
| Latest commit: |
506d80b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f25045d.openapi-ts.pages.dev |
| Branch Preview URL: | https://fix-complex-one-of.openapi-ts.pages.dev |
drwpow
force-pushed
the
fix-complex-one-of
branch
from
0603110 to
506d80b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1019. At
oneOflength of > 5, fall back to TS unions rather than the complex customOneOf<>(XOR) comparison.This is tough because it’s hard to predict just how complex some types would be, so there’s not a correct number. But hopefully most people see an invisible improvement in types, and if we see new issues come in we’ll adjust based on feedback.
How to Review
See #1019 for context.
Checklist
examples/directory updated (only applicable for openapi-typescript)