Fix mutating $refs in Node.js API #1203
Conversation
🦋 Changeset detectedLatest commit: 62a6524 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
fix-schema-mutation
branch
from
bd7e8b9 to
0fd610d
Compare
Deploying with
|
| Latest commit: |
62a6524
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6ee627e.openapi-ts.pages.dev |
| Branch Preview URL: | https://fix-schema-mutation.openapi-ts.pages.dev |
drwpow
force-pushed
the
fix-schema-mutation
branch
3 times, most recently
from
40db951 to
8488a47
Compare
drwpow
force-pushed
the
fix-schema-mutation
branch
from
8488a47 to
62a6524
Compare
| @@ -173,7 +173,7 @@ export default async function load(schema: URL | Subschema | Readable, options: | |||
| else if (typeof schema === "object") { | |||
| options.schemas[schemaID] = { | |||
| hint: "OpenAPI3", | |||
| schema: schema as any, | |||
| schema: JSON.parse(JSON.stringify(schema)), // create deep clone of inline schema (don’t mutate) | |||
There was a problem hiding this comment.
So funny enough, after some lazy performance testing in V8, JSON.parse(JSON.stringify(…)) was faster than structuredClone(). Which I guess makes sense with JSON-serializable data that we’re working with. I imagine it‘s also because structuredClone() hasn’t had as much time to be optimized, comparatively. But I’d hope long-term the latter would be faster.
This is probably not that much of a hack as I originally thought it was. And this only runs in the Node.js API (only when needed)
Changes
Fixes #1178.
How to Review
N/A
Checklist
examples/directory updated (only applicable for openapi-typescript)