fix: Avoid index signature error for paths with empty params #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5a9a48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
horaklukas
force-pushed
the
fix/empty-params-in-path
branch
from
6f9599e to
f5a9a48
Compare
drwpow
approved these changes
Jun 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It fixes using
--path-as-params-typesoption for paths that doesn't contain a param (like/api/user). In that case, using the option causes generating path name as[path: '/api/user']and produces compiler errorAn index signature parameter type cannot be a literal type or generic type. Consider using a mapped object type instead.How to Review
It fixes this fix. The
pathParamsvariable is already non-empty variable, but can have empty size.Checklist
examples/directory updated (only applicable for openapi-typescript) - not necessary [bugfix]