De-duplicate unions. #1069
De-duplicate unions. #1069
Conversation
| @@ -91489,7 +91489,7 @@ export interface operations { | |||
| /** @description The [status](https://docs.github.com/rest/commits/statuses) contexts to verify against commit status checks. If you omit this parameter, GitHub verifies all unique contexts before creating a deployment. To bypass checking entirely, pass an empty array. Defaults to all unique contexts. */ | |||
| required_contexts?: (string)[]; | |||
| payload?: OneOf<[{ | |||
| [key: string]: unknown | undefined; | |||
There was a problem hiding this comment.
this is pretty nice
|
Hm, I think this happens to fix #810 as well. Currently, a schema like this: MetaQuote:
oneOf: []
discriminator:
propertyName: meta_serialization_key
mapping: {}generates like so: export interface components {
schemas: {
MetaQuote: ; // error here
};
}Now, we default to export interface components {
schemas: {
MetaQuote: never;
};
}which I believe is what we expect, right? I can add a more specific regression test for this if we want. |
| const members = new Set<string>(); | ||
| for (const t of types) { | ||
| // unknown swallows everything else in the union | ||
| if (t === "unknown") return "unknown"; |
There was a problem hiding this comment.
ah this is smart! I hadn’t considered this ❤️
| } | ||
|
|
||
| // never gets swallowed by anything else, so only return never | ||
| // if it is the only member |
|
Really appreciate all your awesome work on this library, and your helpfulness in the issues! I accept your offer to help and have invited you to have maintaner access 🙂. PRs still require approval from another maintainer, but you can at least open PRs and triage issues easier now. Thank you so much! 🙏 |
|
When you get accept access to this project, I’ll let you merge this one 🙂 |
mitchell-merry
force-pushed
the
mitchell-merry/dedupe-unions
branch
from
0045587 to
80fa7af
Compare
Changes
If a union has multiple members that are the same, then we should de-duplicate them.
#1049 (comment)
How to Review
Checklist
examples/directory updated (if applicable)