Fix oneOf number const
#1056
Merged
Fix oneOf number const
#1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
reviewed
Mar 30, 2023
| @@ -98,7 +98,7 @@ export function defaultSchemaObjectTransform( | |||
| // oneOf (no discriminator) | |||
| if ("oneOf" in schemaObject && !schemaObject.oneOf.some((t) => "$ref" in t && ctx.discriminators[t.$ref])) { | |||
| const maybeTypes = schemaObject.oneOf.map((item) => transformSchemaObject(item, { path, ctx })); | |||
| if (maybeTypes.some((t) => t.includes("{"))) return tsOneOf(...maybeTypes); // OneOf<> helper needed if any objects present ("{") | |||
| if (maybeTypes.some((t) => typeof t === "string" && t.includes("{"))) return tsOneOf(...maybeTypes); // OneOf<> helper needed if any objects present ("{") | |||
drwpow
reviewed
Mar 30, 2023
| @@ -62,7 +62,7 @@ export function defaultSchemaObjectTransform( | |||
| } | |||
|
|
|||
| // const (valid for any type) | |||
| if (schemaObject.const) { | |||
| if (schemaObject.const !== null && schemaObject.const !== undefined) { | |||
drwpow
reviewed
Mar 30, 2023
| @@ -0,0 +1,21 @@ | |||
| import { tsUnionOf } from "../src/utils"; | |||
|
|
|||
| describe("utils", () => { | |||
There was a problem hiding this comment.
These tests aren’t really necessary as they are all tested by proxy with other tests, and these are such simple functions with such simple inputs/outputs they have clear and obvious failures.
However, the coverage is appreciated and it doesn’t hurt to have. Thank you.
|
@all-contributors please add @qnp for code, bug, test |
|
I've put up a pull request to add @qnp! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixing #1051 alongside the fact that
0as a const value was evicted.How to Review
I wrote tests, they all pass now.
FYI, I wanted to make sure everything is working as expected, so I added tests for the
tsOneOfutil. IMHO, all the utils should be tested (but I did not have time to write these tests).Checklist
examples/directory updated (if applicable)