-
-
Notifications
You must be signed in to change notification settings - Fork 528
Fix breaking JSDoc changes (#1012) #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
6755f95
to
05756e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great fix, and great tests. Thank you! Will merge as soon as the lint errors & minor conflicts are resolved.
I contribute as much time to the project as I can, which is several hours every month. I’d love help with additional maintainers if you’re interested or know someone who is. |
05756e8
to
6de4d26
Compare
Thanks! Could you rerun the workflow? I'm getting
That's good to hear. I want to start using this package, so I'm hoping that it's still being at least somewhat maintained. As long as I can submit PRs and there's someone around to check them, that's good by me :D thanks for what you do. Edit: Seems good, just needs a merge! @drwpow |
@all-contributors please add @mitchell-merry for code, test, bug |
I've put up a pull request to add @mitchell-merry! 🎉 |
Changes
Fixes #1012
The example linked in the issue now generates as:
How to Review
The tests were wrong in this instance, so they have been updated as well.
Checklist
examples/
directory updated (if applicable)