Implement Webhooks #1001
Merged
Implement Webhooks #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great to me! Great tests, too. Additions like this are pretty safe (there’s no existing functionality that may break) so I’m happy to merge & ship this. No feedback! |
drwpow
approved these changes
Nov 23, 2022
|
@all-contributors please add @yacinehmito for code, test |
|
I've put up a pull request to add @yacinehmito! 🎉 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implements webhooks. I am usually verbose in my PR descriptions but here the change is quite straightforward. The specs define
webhooksas being identical topaths(with the exception that it does not have actual paths), so I just copy-pasted the implementation for paths and removed the bit that relates topathParamsAsTypes.Fixes #994.
How to Review
I don't know. There was a lot of changes in the test due to the inclusion of
export type webhooks = Record<string, never>;, but the only test that is actually relevant is the "GitHub (next)" snapshot, which is the only one with webhooks (the normal GitHub one has them as well but on a non-standard property, which isx-webhooks).For the unit test I took inspiration from the paths' one. I hope it is sufficient.
Checklist
examples/directory updated (if applicable)I don't think there is anything to add in the README.