Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes issue 81, model instance in new #82

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Nov 18, 2022

Fixes issue 81, model instance in new
New test added for verification

With my update, this test code passes:

ev = event.Event(name="test", properties={"name": "test"})
er = event_request.EventRequest(event=ev)
self.assertEqual(
    er,
    {
        'event': {
            'name': 'test',
            'properties': {'name': 'test'}
        }
    }
)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether added this to the 1.0.4 milestone Nov 18, 2022
@spacether spacether linked an issue Nov 18, 2022 that may be closed by this pull request
6 tasks
@spacether spacether merged commit 8bf45d9 into master Nov 18, 2022
@spacether spacether deleted the issue_81_model_instance_in_new branch November 18, 2022 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] passing in model instance into __new__ raises error
1 participant