Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes low spec version bug #74

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Fixes low spec version bug #74

merged 1 commit into from
Nov 11, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Nov 11, 2022

The generate command was succeeding with specs < v3.0.0 which is not supported.
This fixes that bug.
v2.0.0 specs are not supported because they are very old and because I have seen parsing bugs in them that do not exist in v3.0.0 specs.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether linked an issue Nov 11, 2022 that may be closed by this pull request
6 tasks
@spacether spacether added this to the 1.0.3 milestone Nov 11, 2022
@spacether spacether merged commit d6a611b into master Nov 11, 2022
@spacether spacether deleted the fixes_low_spec_version_bug branch November 11, 2022 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v2 spec generation succeeds when it should throw an error
1 participant