Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes enum variable names #401

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fixes enum variable names #401

merged 2 commits into from
Mar 6, 2024

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Mar 6, 2024

Fixes enum variable names

  • only allows a-ZA-Z characters in for the first character, if it isn't, convert it using the character name
  • for later characters only allow 0-9a-z-A-Z, if it isn't, convert it using the character name

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether linked an issue Mar 6, 2024 that may be closed by this pull request
6 tasks
@spacether spacether merged commit c5589a9 into master Mar 6, 2024
@spacether spacether deleted the fix_enum_var_names branch March 6, 2024 18:56
@spacether spacether mentioned this pull request Mar 6, 2024
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error transforming enum values beginning with numbers
1 participant