Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes query param content type json serialization #33

Merged
merged 9 commits into from
Oct 7, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 6, 2022

Query parameter content-type json serialization was broken, so I fixed it
This PR

  • fixes that feature
  • adds a test of query param content type json serialization in test_query_content_json_serialization
  • adds an endpoint to the sample spec that uses it at /fake/queryParamWithJsonContentType
  • adds a verification endpoint method call for that endpoint at TestFakeQueryParamWithJsonContentType.test_get

This issue made me realize that the query parameter json serialization is broken and needs:

  • whitespace removal between items and key value pairs
  • percent encoding of values

When working on this issue, I filed this issue for the future:
#34

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether added this to the 1.0.1 milestone Oct 6, 2022
@spacether spacether changed the title Improves query param content type json serialization tests Fixes query param content type json serialization Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant