-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for application/x-pem-file MIME type #280
Add support for application/x-pem-file MIME type #280
Conversation
Not sure why the CI fails. I’ve run the scripts mentioned in the PR template to update the samples but it looks like it did not work. |
Thank you for the PR. Can you please run these steps and then commit the changes?
CI is failing because the repo samples have changes when they are regenerated with your fix. |
Oh, I ran the script, added the files but forgot to amend the commit. 🤦 Should be fixed now. |
… and rebased onto master. |
This patch adds support for serializing and deserializing data with the application/x-pem-file MIME type as plain text. Fixes: openapi-json-schema-tools#244
… and finally fixed the CI. |
Thank you for making those changes. The PR as-is has no tests verifying that it works. If we leave it as-is a future PR could break this functionality without generating a test error signal.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. I never heard back from you about adding a test so I will add one after merging it.
@spacether Thank you! I started working on the test but got stuck figuring out the details of the test setup, so I very much appreciate you adding the test. |
This patch adds support for serializing and deserializing data with the application/x-pem-file MIME type as plain text.
Fixes: #244
Minimal example:
Real world example: Nitrokey/nethsm-sdk-py#65
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*
.For Windows users, please run the script in Git BASH.