Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Adds pathItem common parameters #256

Merged
merged 25 commits into from
Oct 20, 2023
Merged

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 17, 2023

  • Adds pathItem common parameters which are parameters defined at the path Item level(not at operation level)
  • py files written for pathItem parameters
  • parameters are used in endpoint operations if needed. They can be overridden. That override use case is included.
  • refactors CodegenOperation to use a new ParameterCollection class to hold all/path/query/header/cookie parameters. Uses that class to store operation parameters and pathItem parameters for an operation
  • added 3 tests of python routes that use path Item common parameters, one where the parameter is overridden

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft October 17, 2023 20:02
@spacether spacether changed the title Adds path common parameters Adds pathItem common parameters Oct 17, 2023
@spacether spacether linked an issue Oct 20, 2023 that may be closed by this pull request
@spacether spacether marked this pull request as ready for review October 20, 2023 20:47
@spacether spacether merged commit 4806ecd into master Oct 20, 2023
@spacether spacether deleted the issue_237_common_parameters branch October 20, 2023 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][python] Common parameter for a path not working
1 participant